Skip to content

[stable 1.96.0] Patch libssh2-sys#17140

Merged
weihanglo merged 6 commits into
rust-lang:rust-1.96.0from
ehuss:libssh2-sys-patch
Jun 26, 2026
Merged

[stable 1.96.0] Patch libssh2-sys#17140
weihanglo merged 6 commits into
rust-lang:rust-1.96.0from
ehuss:libssh2-sys-patch

Conversation

@ehuss

@ehuss ehuss commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This imports a copy of libssh2-sys 0.9.5 with 3 CVE fixes applied.

This is intended to be temporary until the upstream fixes get merged and a new release is made. See https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/libssh2.20backport.20for.20cargo.20release/with/606766672

ehuss and others added 4 commits June 26, 2026 09:47
This imports libssh2-sys 0.3.1 from commit
7fa55ea97e086d69d96267f4a1b84137a5514582 in order to patch a CVE fix.
…LL_PACKET path

Backport of upstream commit 97acf3dfda80c91c3a8c9f2372546301d4a1a7a8
…ndler

Backport of upstream commit 17626857d20b3c9a1addfa45979dadcee1cd84a4
…n malformed packet

Backport of upstream commit 2dae3024897e1898d389835151f4e9606227721d
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2026
@rustbot

rustbot commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from epage, weihanglo

@rustbot

rustbot commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.96.0. Please double check that you specified the right target!

@rustbot rustbot added the A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. label Jun 26, 2026
@ehuss ehuss changed the title Patch libssh2-sys [stable 1.96.0] Patch libssh2-sys Jun 26, 2026
@weihanglo

Copy link
Copy Markdown
Member

The job failure is inherently a problem of Cargo patching. We normally don't want to check the code in patched crates but they are considered "local" so no cap-lints on them.

@weihanglo weihanglo enabled auto-merge June 26, 2026 17:31
@weihanglo

Copy link
Copy Markdown
Member

The job failure is inherently a problem of Cargo patching. We normally don't want to check the code in patched crates but they are considered "local" so no cap-lints on them.

Hmm… I was wrong it was not this case.

@weihanglo weihanglo merged commit 3569272 into rust-lang:rust-1.96.0 Jun 26, 2026
30 of 31 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2026
@rustbot rustbot added this to the 1.96.1 milestone Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants