test: Fixed arg order in rustdoc json test#16968
Merged
weihanglo merged 1 commit intorust-lang:masterfrom May 6, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
May 6, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While rebasing #16807 I notice a new test was added in #16773 that passes
-Zbuild-dir-new-layoutbut the test isasserting the old layout. Which I was initially quite confused by.After investigating I realized it was due to
-Zflags being before and after the command.Moving the
-Zunstable-optionsbefore the command fixes the issue. (moving-Zbuild-dir-new-layoutafter the command also works)Not quite sure if this is a bug or just initiative behavior.
I do not see it documented in https://doc.rust-lang.org/cargo/reference/unstable.html so if its expected I think it might be worth documenting.
Maybe related: #15589