Rebuild when -Zpublic-dependency changes#16965
Open
qaijuang wants to merge 1 commit intorust-lang:masterfrom
Open
Rebuild when -Zpublic-dependency changes#16965qaijuang wants to merge 1 commit intorust-lang:masterfrom
qaijuang wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
A-build-execution
qaijuang
changed the title
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16962.
What does this PR try to resolve?
-Zpublic-dependencychanges how Cargo passes private dependencies to rustc for library units. With the option enabled, Cargo marks private dependencies withprivin--externso rustc can run theexported_private_dependencieslint.The fingerprint config hash did not include that effective mode, so toggling
-Zpublic-dependencycould leave the library fresh even though the rustc invocation should change.This PR hashes the effective condition that changes the
--externargs and keeps the predicate shared withextern_args.How to test and review this PR?
The new test covers both stale directions:
-Zpublic-dependency, then without it-Zpublic-dependency, then with it