fix(path): clarify error message when path dependency has wrong package by raushan728 · Pull Request #16927 · rust-lang/cargo

raushan728 · 2026-04-22T10:39:39Z

When a path dependency points to a directory with a wrong or missing package, Cargo now scans subdirectories and shows helpful hints about what packages exist nearby.

rustbot · 2026-04-22T10:39:44Z

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ehuss, @epage, @weihanglo
@ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
Random selection from ehuss, epage, weihanglo

epage

Thanks!

View changes since this review

raushan728 · 2026-04-30T07:08:10Z

Since PathSource::query() now returns zero candidates for missing Cargo.toml instead of an IO error, some existing tests that expected the old error chain now show the resolver-level error message instead.

Track missing Cargo.toml state using Option<Option<Package>>, where outer None means unloaded and inner None means loaded but missing. This allows the resolver to produce standard diagnostics instead of raw IO error chains.

rustbot · 2026-07-19T08:11:19Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

- Scan subdirectories when a path dependency is missing or invalid. - Show helpful hints suggesting packages that exist nearby.

epage

Thanks!

View changes since this review

Update cargo submodule 17 commits in 3efb1f477e99b42974b982d939fd100303cdf7db..54b61f13a4eea47ec3ee95237d4107976d7909ed 2026-07-17 23:53:19 +0000 to 2026-07-24 13:23:18 +0000 - chore: bump to `[email protected]+1.9.6` (rust-lang/cargo#17259) - Enable build-dir layout v2 on nightly by default (rust-lang/cargo#17258) - fix(path): clarify error message when path dependency has wrong package (rust-lang/cargo#16927) - fix(toml): warn on hyphenated lint names and duplicates (rust-lang/cargo#17051) - fix(test): gate trim-paths tests on split debuginfo support (rust-lang/cargo#17256) - test(git): Explicitly test for git injection attacks (rust-lang/cargo#17253) - fix(git): Suggest libgit2 if git-cli fails (rust-lang/cargo#17252) - fix(diag): bound transitive unused dependency traversal (rust-lang/cargo#17251) - fix(git): Hide git fetch output without progress (rust-lang/cargo#17243) - revert(lint): Remove `new_implicit_minimum_version_req` (rust-lang/cargo#16321) (rust-lang/cargo#17249) - fix: Add haiku's dylib path (rust-lang/cargo#17248) - Zsh completion: Add `-p` and `--package` flags for `cargo add` (rust-lang/cargo#17247) - refactor(source): Clarify the name of the remote git registry (rust-lang/cargo#17240) - fix(timings): only report units the job queue actually ran (rust-lang/cargo#17238) - Do not include proc-macro deps in rustc search path args (rust-lang/cargo#17236) - chore(deps): update cargo-semver-checks to v0.49.0 (rust-lang/cargo#17237) - rustdoc: rename the doc parts metadata params (rust-lang/cargo#17234) r? ghost

rustbot added A-dependency-resolution Area: dependency resolution and the resolver S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026

rustbot assigned epage Apr 22, 2026

epage reviewed Apr 22, 2026

View reviewed changes

raushan728 force-pushed the fix-15296 branch from 1978dbb to bacfa17 Compare April 23, 2026 11:34

rustbot added the A-registries Area: registries label Apr 23, 2026

This comment has been minimized.

Sign in to view

raushan728 requested a review from epage April 23, 2026 12:47

epage reviewed Apr 23, 2026

View reviewed changes

Comment thread src/cargo/core/resolver/errors.rs

epage reviewed Apr 23, 2026

View reviewed changes

Comment thread src/cargo/core/resolver/errors.rs Outdated

epage reviewed Apr 23, 2026

View reviewed changes

Comment thread src/cargo/core/resolver/errors.rs Outdated

epage reviewed Apr 23, 2026

View reviewed changes

Comment thread src/cargo/core/registry.rs Outdated

raushan728 force-pushed the fix-15296 branch 3 times, most recently from d5f8d89 to 603d687 Compare April 24, 2026 06:58

This comment was marked as duplicate.

Sign in to view

raushan728 requested a review from epage April 26, 2026 14:48

epage reviewed Apr 27, 2026

View reviewed changes

Comment thread src/resolver/errors.rs

epage reviewed Apr 27, 2026

View reviewed changes

Comment thread src/cargo/core/resolver/errors.rs Outdated

raushan728 force-pushed the fix-15296 branch from 603d687 to 744492b Compare April 30, 2026 07:05

This comment has been minimized.

Sign in to view

raushan728 force-pushed the fix-15296 branch 2 times, most recently from 94076b6 to fb20a60 Compare May 1, 2026 08:54

raushan728 requested a review from epage May 1, 2026 09:20

raushan728 force-pushed the fix-15296 branch from fb20a60 to 0d5ca85 Compare May 5, 2026 09:35

This comment has been minimized.

Sign in to view

epage reviewed May 10, 2026

View reviewed changes

Comment thread src/cargo/sources/path.rs Outdated

epage reviewed May 10, 2026

View reviewed changes

Comment thread src/sources/path.rs

epage reviewed May 11, 2026

View reviewed changes

Comment thread src/cargo/sources/path.rs Outdated

raushan728 force-pushed the fix-15296 branch from 87ed57e to 87b114b Compare May 12, 2026 05:38

This comment has been minimized.

Sign in to view

raushan728 force-pushed the fix-15296 branch 2 times, most recently from 142213e to 2fb9cd0 Compare May 12, 2026 06:53

raushan728 requested a review from epage May 12, 2026 07:23

raushan728 force-pushed the fix-15296 branch from 2fb9cd0 to a9df55a Compare May 14, 2026 08:16

This comment has been minimized.

Sign in to view

raushan728 closed this May 14, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2026

raushan728 reopened this May 14, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2026

raushan728 force-pushed the fix-15296 branch from a9df55a to 21fa9b6 Compare May 22, 2026 15:57

This comment has been minimized.

Sign in to view

raushan728 added 2 commits July 19, 2026 07:58

test(path): add tests for path dependency wrong package error message

aa66c48

fix(path): handle missing Cargo.toml gracefully in PathSource

626093f

Track missing Cargo.toml state using Option<Option<Package>>, where outer None means unloaded and inner None means loaded but missing. This allows the resolver to produce standard diagnostics instead of raw IO error chains.

raushan728 force-pushed the fix-15296 branch from 21fa9b6 to 4602528 Compare July 19, 2026 08:11

fix(path): suggest nearby packages for invalid path dependencies

d91fa9f

- Scan subdirectories when a path dependency is missing or invalid. - Show helpful hints suggesting packages that exist nearby.

raushan728 force-pushed the fix-15296 branch from 4602528 to d91fa9f Compare July 19, 2026 08:43

epage approved these changes Jul 22, 2026

View reviewed changes

epage added this pull request to the merge queue Jul 22, 2026

Merged via the queue into rust-lang:master with commit 5b6fca7 Jul 22, 2026
29 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2026

raushan728 deleted the fix-15296 branch July 24, 2026 05:20

weihanglo mentioned this pull request Jul 24, 2026

Update cargo submodule rust-lang/rust#159857

Open

Uh oh!

Uh oh!

Conversation

raushan728 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 22, 2026

Uh oh!

epage left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

This comment has been minimized.

raushan728 commented Apr 30, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 19, 2026

Uh oh!

epage left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raushan728 commented Apr 22, 2026 •

edited

Loading

epage left a comment •

edited by rustbot

Loading

epage left a comment •

edited by rustbot

Loading