Skip to content

fix(resolver): Better match rustc in error styling#16795

Merged
weihanglo merged 12 commits intorust-lang:masterfrom
epage:resolver-error
Mar 27, 2026
Merged

fix(resolver): Better match rustc in error styling#16795
weihanglo merged 12 commits intorust-lang:masterfrom
epage:resolver-error

Conversation

@epage
Copy link
Copy Markdown
Contributor

@epage epage commented Mar 26, 2026

What does this PR try to resolve?

The original motivation was to find ways to make some of the suggestions stand out more but we generally had a wording and organization mismatch with rustc

See #t-cargo > wrong missing feature reported with `target`-gated deps @ 💬

How to test and review this PR?

@rustbot rustbot added A-dependency-resolution Area: dependency resolution and the resolver S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 26, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

@weihanglo weihanglo enabled auto-merge March 27, 2026 14:49
@weihanglo weihanglo added this pull request to the merge queue Mar 27, 2026
Merged via the queue into rust-lang:master with commit ddb37b0 Mar 27, 2026
31 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2026
@epage epage deleted the resolver-error branch March 27, 2026 16:09
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Mar 28, 2026
Update cargo submodule

10 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..ddb37b06aba4dcf791fde56dd9fcf73ae7d05f7f
2026-03-21 01:27:07 +0000 to 2026-03-27 15:01:07 +0000
- fix(resolver): Better match rustc in error styling (rust-lang/cargo#16795)
- missing -Zjson-target-spec error: mention that this is a cargo flag (rust-lang/cargo#16793)
- Update changelog for 1.94.1 (rust-lang/cargo#16789)
- test(build): Make it easier to review `build.warnings` behavior (rust-lang/cargo#16788)
- test(build): Cover more behavior of `build.warnings` (rust-lang/cargo#16785)
- chore(deps): bump curl-sys from 0.4.83 to 0.4.86 (rust-lang/cargo#16786)
- Warn when installing with a non-default toolchain (rust-lang/cargo#16131)
- feat(cli): Add support for completing `--config` argument values with `native-completions` (rust-lang/cargo#16249)
- feat(cli): complete `--config` and `--color` before command (rust-lang/cargo#16780)
- chore(deps): bump rustls-webpki from 0.103.9 to 0.103.10 (rust-lang/cargo#16778)

r? ghost
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Mar 31, 2026
Update cargo submodule



11 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..888f675344eb1cf2308fd53183e667bdd2c58e51
2026-03-21 01:27:07 +0000 to 2026-03-30 16:59:25 +0000
- chore: bump to [email protected] (rust-lang/cargo#16808)
- fix(resolver): Better match rustc in error styling (rust-lang/cargo#16795)
- missing -Zjson-target-spec error: mention that this is a cargo flag (rust-lang/cargo#16793)
- Update changelog for 1.94.1 (rust-lang/cargo#16789)
- test(build): Make it easier to review `build.warnings` behavior (rust-lang/cargo#16788)
- test(build): Cover more behavior of `build.warnings` (rust-lang/cargo#16785)
- chore(deps): bump curl-sys from 0.4.83 to 0.4.86 (rust-lang/cargo#16786)
- Warn when installing with a non-default toolchain (rust-lang/cargo#16131)
- feat(cli): Add support for completing `--config` argument values with `native-completions` (rust-lang/cargo#16249)
- feat(cli): complete `--config` and `--color` before command (rust-lang/cargo#16780)
- chore(deps): bump rustls-webpki from 0.103.9 to 0.103.10 (rust-lang/cargo#16778)
@rustbot rustbot added this to the 1.96.0 milestone Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependency-resolution Area: dependency resolution and the resolver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants