feat(cli): complete --config and --color before command#16780
Merged
weihanglo merged 1 commit intorust-lang:masterfrom Mar 22, 2026
Merged
feat(cli): complete --config and --color before command#16780weihanglo merged 1 commit intorust-lang:masterfrom
--config and --color before command#16780weihanglo merged 1 commit intorust-lang:masterfrom
Conversation
Signed-off-by: Nick Spinale <[email protected]>
rustbot
added
A-completions
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nspin
changed the title
--config and --color before command
weihanglo
approved these changes
Mar 22, 2026
Member
There was a problem hiding this comment.
This is nice. I feel like there are more global options that we might want to have such kind of completions. Not a blocker though.
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Mar 28, 2026
Update cargo submodule 10 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..ddb37b06aba4dcf791fde56dd9fcf73ae7d05f7f 2026-03-21 01:27:07 +0000 to 2026-03-27 15:01:07 +0000 - fix(resolver): Better match rustc in error styling (rust-lang/cargo#16795) - missing -Zjson-target-spec error: mention that this is a cargo flag (rust-lang/cargo#16793) - Update changelog for 1.94.1 (rust-lang/cargo#16789) - test(build): Make it easier to review `build.warnings` behavior (rust-lang/cargo#16788) - test(build): Cover more behavior of `build.warnings` (rust-lang/cargo#16785) - chore(deps): bump curl-sys from 0.4.83 to 0.4.86 (rust-lang/cargo#16786) - Warn when installing with a non-default toolchain (rust-lang/cargo#16131) - feat(cli): Add support for completing `--config` argument values with `native-completions` (rust-lang/cargo#16249) - feat(cli): complete `--config` and `--color` before command (rust-lang/cargo#16780) - chore(deps): bump rustls-webpki from 0.103.9 to 0.103.10 (rust-lang/cargo#16778) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Mar 31, 2026
Update cargo submodule 11 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..888f675344eb1cf2308fd53183e667bdd2c58e51 2026-03-21 01:27:07 +0000 to 2026-03-30 16:59:25 +0000 - chore: bump to [email protected] (rust-lang/cargo#16808) - fix(resolver): Better match rustc in error styling (rust-lang/cargo#16795) - missing -Zjson-target-spec error: mention that this is a cargo flag (rust-lang/cargo#16793) - Update changelog for 1.94.1 (rust-lang/cargo#16789) - test(build): Make it easier to review `build.warnings` behavior (rust-lang/cargo#16788) - test(build): Cover more behavior of `build.warnings` (rust-lang/cargo#16785) - chore(deps): bump curl-sys from 0.4.83 to 0.4.86 (rust-lang/cargo#16786) - Warn when installing with a non-default toolchain (rust-lang/cargo#16131) - feat(cli): Add support for completing `--config` argument values with `native-completions` (rust-lang/cargo#16249) - feat(cli): complete `--config` and `--color` before command (rust-lang/cargo#16780) - chore(deps): bump rustls-webpki from 0.103.9 to 0.103.10 (rust-lang/cargo#16778)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Split from #16245 (see #16245 (comment)).
Currently,
cargo.bashcomp.shsupports completing values for--colorand--configonly in cases where they appear after the subcommand. This PR add support for completing values for these two flags when they appear before the subcommand.How to test and review this PR?
In a Bash shell, run:
Before this patch, the following behaves as expected (suggests colors or paths):
but the following does not behave as expected (colors or paths are not suggested):
With this patch applied, all of the following behave as expected: