Skip to content

Consider preserving mtimes of archives #7590

@SimonSapin

Description

@SimonSapin

#7465 disabled preserving modification times when extracting tarballs.

Some crates have a build script that runs make or some other tool that look at mtimes to decide whether to (re)build some generated files. Some of them ship with some files pre-generated, in order to reduce system dependencies for users.

This seems to be the case of https://crates.io/crates/harfbuzz-sys. In recent versions of Cargo, it intermittently fails to build if Ragel is not available: servo/servo#24611

Although this situation is maybe not common, preserving mtimes would avoid this kind of failure or at least make them deterministic. Should #7465 be reverted?

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-filesystemArea: issues with filesystemsA-rebuild-detectionArea: rebuild detection and fingerprintingC-bugCategory: bug

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions