-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Allow specifying pull request deps using the github PR link #15001
Copy link
Copy link
Closed
Labels
A-crate-dependenciesArea: [dependencies] of any kindArea: [dependencies] of any kindA-diagnosticsArea: Error and warning messages generated by Cargo itself.Area: Error and warning messages generated by Cargo itself.A-gitArea: anything dealing with gitArea: anything dealing with gitA-patchArea: [patch] table overrideArea: [patch] table overrideC-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`S-triageStatus: This issue is waiting on initial triage.Status: This issue is waiting on initial triage.
Metadata
Metadata
Assignees
Labels
A-crate-dependenciesArea: [dependencies] of any kindArea: [dependencies] of any kindA-diagnosticsArea: Error and warning messages generated by Cargo itself.Area: Error and warning messages generated by Cargo itself.A-gitArea: anything dealing with gitArea: anything dealing with gitA-patchArea: [patch] table overrideArea: [patch] table overrideC-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`S-triageStatus: This issue is waiting on initial triage.Status: This issue is waiting on initial triage.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Problem
From time to time I need to submit a PR to a lib and then want to rely on that PR in my local code.
Every time I do this I have to search the docs to work out the specific syntax that I need.
It would be nice if I could just use GitHub's PR syntax for this (or at the very least the error message should point me in the right direction)
Proposed Solution
Option 1. Support this as-is:
I understand why this might not be ideal even if it's the most developer friendly fix for this. So alternatively:
Option 2. Provide a better error message for this scenario that provides the right syntax:
Current error message:
Expected error message (something like):
Notes
I understand that there's other code forges than GitHub, but it's reasonable to fix the 99% case even when other cases are not fixed.