Apply suggestions from code review

mo8it · weihanglo · web-flow · commit af04e54235ef · 2024-08-09T15:42:02.000+02:00
Inline variables in `format!`

Co-authored-by: Weihang Lo &lt;weihanglo@users.noreply.github.com&gt;
diff --git a/crates/rustfix/tests/parse_and_replace.rs b/crates/rustfix/tests/parse_and_replace.rs
@@ -234,7 +234,7 @@ fn get_fixture_files(p: &str) -> Result<Vec<PathBuf>, Error> {
 
 fn assert_fixtures(dir: &str, mode: &str) {
     let files = get_fixture_files(dir)
-        .with_context(|| format!("couldn't load dir `{}`", dir))
+        .with_context(|| format!("couldn't load dir `{dir}`"))
         .unwrap();
     let mut failures = 0;
 
diff --git a/src/cargo/ops/cargo_add/mod.rs b/src/cargo/ops/cargo_add/mod.rs
@@ -1087,7 +1087,7 @@ fn find_workspace_dep(toml_key: &str, root_manifest: &Path) -> CargoResult<Depen
         .context("could not make `dependencies` into a table")?;
     let dep_item = dependencies
         .get(toml_key)
-        .with_context(|| format!("could not find {} in `workspace.dependencies`", toml_key))?;
+        .with_context(|| format!("could not find {toml_key} in `workspace.dependencies`"))?;
     Dependency::from_toml(root_manifest.parent().unwrap(), toml_key, dep_item)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1087,7 +1087,7 @@ fn find_workspace_dep(toml_key: &str, root_manifest: &Path) -> CargoResult<Depen`
`1087`	`1087`	.context("could not make `dependencies` into a table")?;
`1088`	`1088`	`let dep_item = dependencies`
`1089`	`1089`	`.get(toml_key)`
`1090`		- .with_context(\|\| format!("could not find {} in `workspace.dependencies`", toml_key))?;
	`1090`	+ .with_context(\|\| format!("could not find {toml_key} in `workspace.dependencies`"))?;
`1091`	`1091`	`Dependency::from_toml(root_manifest.parent().unwrap(), toml_key, dep_item)`
`1092`	`1092`	`}`
`1093`	`1093`