Add proc_macro to the extern prelude.

ehuss · ehuss · commit 4d64eb99a4bf · 2019-12-12T16:56:38.000-08:00
diff --git a/src/cargo/core/compiler/build_context/target_info.rs b/src/cargo/core/compiler/build_context/target_info.rs
@@ -39,6 +39,8 @@ pub struct TargetInfo {
     pub rustflags: Vec<String>,
     /// Extra flags to pass to `rustdoc`, see `env_args`.
     pub rustdocflags: Vec<String>,
+    // Remove this when it hits stable (1.41).
+    pub supports_pathless_extern: Option<bool>,
 }
 
 /// Kind of each file generated by a Unit, part of `FileType`.
@@ -101,6 +103,13 @@ impl TargetInfo {
             .args(&rustflags)
             .env_remove("RUSTC_LOG");
 
+        let mut pathless_test = process.clone();
+        pathless_test.args(&["--extern", "proc_macro"]);
+        let supports_pathless_extern = match kind {
+            CompileKind::Host => Some(rustc.cached_output(&pathless_test).is_ok()),
+            _ => None,
+        };
+
         if let CompileKind::Target(target) = kind {
             process.arg("--target").arg(target.rustc_target());
         }
@@ -183,6 +192,7 @@ impl TargetInfo {
                 "RUSTDOCFLAGS",
             )?,
             cfg,
+            supports_pathless_extern,
         })
     }
 
diff --git a/src/cargo/core/compiler/mod.rs b/src/cargo/core/compiler/mod.rs
@@ -1010,6 +1010,17 @@ pub fn extern_args<'a>(
             link_to(&dep, dep.extern_crate_name, dep.noprelude)?;
         }
     }
+    if unit.target.proc_macro()
+        && cx
+            .bcx
+            .info(CompileKind::Host)
+            .supports_pathless_extern
+            .unwrap()
+    {
+        // Automatically import `proc_macro`.
+        result.push(OsString::from("--extern"));
+        result.push(OsString::from("proc_macro"));
+    }
 
     Ok(result)
 }
diff --git a/tests/testsuite/proc_macro.rs b/tests/testsuite/proc_macro.rs
@@ -440,3 +440,37 @@ Caused by:
         .with_status(101)
         .run();
 }
+
+#[cargo_test]
+fn proc_macro_extern_prelude() {
+    if !is_nightly() {
+        // remove once pathless `--extern` hits stable (1.41)
+        return;
+    }
+    // Check that proc_macro is in the extern prelude.
+    let p = project()
+        .file(
+            "Cargo.toml",
+            r#"
+            [package]
+            name = "foo"
+            version = "0.1.0"
+            edition = "2018"
+            [lib]
+            proc-macro = true
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            r#"
+            use proc_macro::TokenStream;
+            #[proc_macro]
+            pub fn foo(input: TokenStream) -> TokenStream {
+                "".parse().unwrap()
+            }
+            "#,
+        )
+        .build();
+    p.cargo("test").run();
+    p.cargo("doc").run();
+}
diff --git a/tests/testsuite/rustc_info_cache.rs b/tests/testsuite/rustc_info_cache.rs
@@ -6,6 +6,11 @@ use std::env;
 
 #[cargo_test]
 fn rustc_info_cache() {
+    if !cargo_test_support::is_nightly() {
+        // remove once pathless `--extern` hits stable (1.41)
+        return;
+    }
+
     let p = project()
         .file("src/main.rs", r#"fn main() { println!("hello"); }"#)
         .build();

Original file line number	Diff line number	Diff line change
`@@ -1010,6 +1010,17 @@ pub fn extern_args<'a>(`
`1010`	`1010`	`link_to(&dep, dep.extern_crate_name, dep.noprelude)?;`
`1011`	`1011`	`}`
`1012`	`1012`	`}`
	`1013`	`+ if unit.target.proc_macro()`
	`1014`	`+ && cx`
	`1015`	`+ .bcx`
	`1016`	`+ .info(CompileKind::Host)`
	`1017`	`+ .supports_pathless_extern`
	`1018`	`+ .unwrap()`
	`1019`	`+ {`
	`1020`	+ // Automatically import `proc_macro`.
	`1021`	`+ result.push(OsString::from("--extern"));`
	`1022`	`+ result.push(OsString::from("proc_macro"));`
	`1023`	`+ }`
`1013`	`1024`
`1014`	`1025`	`Ok(result)`
`1015`	`1026`	`}`