Explicitly state "compilation modes"#3517
Merged
Merged
Conversation
I'm a Rust newbie. When I first read the line "Wrap in all modes...", I first thought that "mode" referred to different modes of the `wrapping_` method. It took me a minute to realise that "mode" referred to the _compilation_ mode! (Maybe I'm a bit sleepy today!) So I'd propose that the text explicitly says "compilation modes", to make the meaning as clear as possible :)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 14, 2026
Update books ## rust-lang/book 3 commits in 05d114287b7d6f6c9253d5242540f00fbd6172ab..dd7ab4f4f4541adf4aa2a872cdac06c206b73288 2026-07-10 19:43:43 UTC to 2026-06-29 20:56:02 UTC - Update to Rust 1.97 (rust-lang/book#4799) - doc: upgrade rand dependency to v0.10.1 in book listings and text (rust-lang/book#4756) - Explicitly state "compilation modes" (rust-lang/book#3517) ## rust-lang/edition-guide 1 commits in c3c0f0b3da26610138b7ba7663f60cd2c68cf184..53686db907c45268d1b323afd9a3545a37abbced 2026-07-10 17:05:04 UTC to 2026-07-10 17:05:04 UTC - Fix typo of key name `resolver.incompatible-rust-versions` (rust-lang/edition-guide#385) ## rust-lang/reference 4 commits in 86635e30bf861a038dc197d7e16fd09e7e514e7a..afdc77bab886d4455c11247cdd32391bfab636ae 2026-07-09 16:48:44 UTC to 2026-07-06 14:48:32 UTC - Fix the tagged-union pattern-matching recommendation (rust-lang/reference#2303) - Structs with no fields or all-ZST fields are ZSTs (rust-lang/reference#2262) - macros.md: fix case (rust-lang/reference#2307) - Bump railroad-dependency (rust-lang/reference#2305) ## rust-lang/rust-by-example 1 commits in d3117f6c873acbbf331c1d510371d061dfcc975c..15308f3e951814ef3475d2b58f48276e6b17b9af 2026-07-06 10:14:39 UTC to 2026-07-06 10:14:39 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#2025)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 14, 2026
Update books ## rust-lang/book 3 commits in 05d114287b7d6f6c9253d5242540f00fbd6172ab..dd7ab4f4f4541adf4aa2a872cdac06c206b73288 2026-07-10 19:43:43 UTC to 2026-06-29 20:56:02 UTC - Update to Rust 1.97 (rust-lang/book#4799) - doc: upgrade rand dependency to v0.10.1 in book listings and text (rust-lang/book#4756) - Explicitly state "compilation modes" (rust-lang/book#3517) ## rust-lang/edition-guide 1 commits in c3c0f0b3da26610138b7ba7663f60cd2c68cf184..53686db907c45268d1b323afd9a3545a37abbced 2026-07-10 17:05:04 UTC to 2026-07-10 17:05:04 UTC - Fix typo of key name `resolver.incompatible-rust-versions` (rust-lang/edition-guide#385) ## rust-lang/reference 4 commits in 86635e30bf861a038dc197d7e16fd09e7e514e7a..afdc77bab886d4455c11247cdd32391bfab636ae 2026-07-09 16:48:44 UTC to 2026-07-06 14:48:32 UTC - Fix the tagged-union pattern-matching recommendation (rust-lang/reference#2303) - Structs with no fields or all-ZST fields are ZSTs (rust-lang/reference#2262) - macros.md: fix case (rust-lang/reference#2307) - Bump railroad-dependency (rust-lang/reference#2305) ## rust-lang/rust-by-example 1 commits in d3117f6c873acbbf331c1d510371d061dfcc975c..15308f3e951814ef3475d2b58f48276e6b17b9af 2026-07-06 10:14:39 UTC to 2026-07-06 10:14:39 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#2025)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 14, 2026
Rollup merge of #159241 - rustbot:docs-update, r=ehuss Update books ## rust-lang/book 3 commits in 05d114287b7d6f6c9253d5242540f00fbd6172ab..dd7ab4f4f4541adf4aa2a872cdac06c206b73288 2026-07-10 19:43:43 UTC to 2026-06-29 20:56:02 UTC - Update to Rust 1.97 (rust-lang/book#4799) - doc: upgrade rand dependency to v0.10.1 in book listings and text (rust-lang/book#4756) - Explicitly state "compilation modes" (rust-lang/book#3517) ## rust-lang/edition-guide 1 commits in c3c0f0b3da26610138b7ba7663f60cd2c68cf184..53686db907c45268d1b323afd9a3545a37abbced 2026-07-10 17:05:04 UTC to 2026-07-10 17:05:04 UTC - Fix typo of key name `resolver.incompatible-rust-versions` (rust-lang/edition-guide#385) ## rust-lang/reference 4 commits in 86635e30bf861a038dc197d7e16fd09e7e514e7a..afdc77bab886d4455c11247cdd32391bfab636ae 2026-07-09 16:48:44 UTC to 2026-07-06 14:48:32 UTC - Fix the tagged-union pattern-matching recommendation (rust-lang/reference#2303) - Structs with no fields or all-ZST fields are ZSTs (rust-lang/reference#2262) - macros.md: fix case (rust-lang/reference#2307) - Bump railroad-dependency (rust-lang/reference#2305) ## rust-lang/rust-by-example 1 commits in d3117f6c873acbbf331c1d510371d061dfcc975c..15308f3e951814ef3475d2b58f48276e6b17b9af 2026-07-06 10:14:39 UTC to 2026-07-06 10:14:39 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#2025)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a Rust newbie. When I first read the line "Wrap in all modes...", I first thought that "mode" referred to different modes of the
wrapping_method. It took me a minute to realise that "mode" referred to the compilation mode! (Maybe I'm a bit sleepy today!) So I'd propose that the text explicitly says "compilation modes", to make the meaning as clear as possible :)