Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing description of cargo update #3541

Closed
seishun opened this issue Feb 17, 2023 · 2 comments · Fixed by #3882
Closed

Confusing description of cargo update #3541

seishun opened this issue Feb 17, 2023 · 2 comments · Fixed by #3882

Comments

@seishun
Copy link
Contributor

seishun commented Feb 17, 2023

  • I have searched open and closed issues and pull requests for duplicates, using these search terms:
    • cargo update
  • I have checked the latest main branch to see if this has already been fixed, in this file:
    • src/ch02-00-guessing-game-tutorial.md

URL to the section(s) of the book with this problem:
https://doc.rust-lang.org/stable/book/ch02-00-guessing-game-tutorial.html#updating-a-crate-to-get-a-new-version

Description of the problem:

When you do want to update a crate, Cargo provides the command update, which will ignore the Cargo.lock file and figure out all the latest versions that fit your specifications in Cargo.toml. Cargo will then write those versions to the Cargo.lock file. Otherwise, by default, Cargo will only look for versions greater than 0.8.3 and less than 0.9.0.

It's unclear what the "otherwise" refers to. One might think the sentence describes what happens when the command isn't used, but that would be incorrect.

Suggested fix:

Drop the "otherwise".

@epage
Copy link

epage commented Mar 27, 2024

I think I'd change "Otherwise, by default" to "In this case"

@chriskrycho
Copy link
Contributor

“In this case” is a good suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants