Fix highlight_source being misaligned when zero or multi-width chars were presennt#400
Merged
epage merged 2 commits intorust-lang:mainfrom Apr 6, 2026
Merged
Conversation
epage
reviewed
Apr 6, 2026
Contributor
There was a problem hiding this comment.
Does the annotation look off on this one?
Contributor
There was a problem hiding this comment.
Still merging since this is a different issue
Member
Author
There was a problem hiding this comment.
I think it looks off due to SVG rendering. 表意文字 takes up 8 display width, and there are 8 ━ in ━━━━━━━━, so it should line up.
epage
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #396:
The root cause of this problem was the fact that we were passing
displaypositions whenset_style_rangeexpectedcharpositions1. Switching to usingcharfixed the issue.Multi-width chars
Before:
After:
Zero-width chars
Before:
After:
Fix #396
Footnotes
Another example of why I need to go and create actual types for
CharPos,DisplayPos, andBytePos↩