Fix panic in replace#398
Merged
epage merged 3 commits intorust-lang:mainfrom Apr 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
replaceis passed astringwhose length is greater thanend - start, it would cause thedrainon the line to panic as the range start was bigger than the range end. To address this, I switched from usingdrainand adding chars to usingsplice, as it does what the code intended.While looking into this, I also realized the true cause was that we were trying to trim the middle of spans that were too short to trim, and decided to fix that as well.
Fixes #391