fix: correctly count tabs for first patch line#373
Merged
Muscraft merged 2 commits intorust-lang:mainfrom Mar 4, 2026
Merged
Conversation
scrabsha
force-pushed
the
fix-371
branch
2 times, most recently
from
c53533a to
231f16c
Compare
scrabsha
changed the title
Muscraft
approved these changes
Mar 4, 2026
Member
Muscraft
left a comment
Muscraft
left a comment
There was a problem hiding this comment.
These types of bugs can be tricky to find and fix, so thank you for working on this! I also want to thank you for making me take another look at this part of the codebase, as it helped me find a few other bugs that I missed when reviewing #357.
Contributor
Author
|
hehe, thank you for your work! i'm having a ton of fun poking at the codebase and learning so many things :) if you find bugs in the future and don't have the time to fix them, let me know: i'd love to help :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #357 (reported in #371).
When computing the indent of the first line of a patch, we must be careful and consider all the line, including the characters preceding the patch itself. Not doing this results in shifted highlighting for the first line of the snippet.
First commit adds the repro described in the issue. Second commit is the fix.