Remove the unspecified check about .get(exhausted_range_inclusive)

Philippe-Cholet · jswrenn · commit f676f2f96451 · 2024-05-14T14:09:02.000Z
`RangeInclusive::is_empty` (rust 1.47+) is in conflict with our MSRV (1.43.1) so we can't use it yet.
The unspecified behavior is documented in `Itertools::get` so we simply remove this.
diff --git a/src/iter_index.rs b/src/iter_index.rs
@@ -52,7 +52,6 @@ where
     type Output = Take<Skip<I>>;
 
     fn index(self, iter: I) -> Self::Output {
-        debug_assert!(!self.is_empty(), "The given `RangeInclusive` is exhausted. The result of indexing with an exhausted `RangeInclusive` is unspecified.");
         iter.skip(*self.start())
             .take((1 + *self.end()).saturating_sub(*self.start()))
     }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ where`
`52`	`52`	`type Output = Take<Skip<I>>;`
`53`	`53`
`54`	`54`	`fn index(self, iter: I) -> Self::Output {`
`55`		- debug_assert!(!self.is_empty(), "The given `RangeInclusive` is exhausted. The result of indexing with an exhausted `RangeInclusive` is unspecified.");
`56`	`55`	`iter.skip(*self.start())`
`57`	`56`	`.take((1 + self.end()).saturating_sub(self.start()))`
`58`	`57`	`}`