get(r: Range) as Skip<Take>

Philippe-Cholet · jswrenn · commit 7a9ce56fc594 · 2024-05-14T14:09:02.000Z
Unless there is a reason to prefer `Take&lt;Skip&gt;` over `Skip&lt;Take&gt;`?!
diff --git a/src/iter_index.rs b/src/iter_index.rs
@@ -37,11 +37,10 @@ impl<I> IteratorIndex<I> for Range<usize>
 where
     I: Iterator,
 {
-    type Output = Take<Skip<I>>;
+    type Output = Skip<Take<I>>;
 
     fn index(self, iter: I) -> Self::Output {
-        iter.skip(self.start)
-            .take(self.end.saturating_sub(self.start))
+        iter.take(self.end).skip(self.start)
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,10 @@ impl<I> IteratorIndex<I> for Range<usize>`
`37`	`37`	`where`
`38`	`38`	`I: Iterator,`
`39`	`39`	`{`
`40`		`- type Output = Take<Skip<I>>;`
	`40`	`+ type Output = Skip<Take<I>>;`
`41`	`41`
`42`	`42`	`fn index(self, iter: I) -> Self::Output {`
`43`		`- iter.skip(self.start)`
`44`		`- .take(self.end.saturating_sub(self.start))`
	`43`	`+ iter.take(self.end).skip(self.start)`
`45`	`44`	`}`
`46`	`45`	`}`
`47`	`46`