use std::thread::scope instead of scoped_threadpool #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it's easier to deal with TSAN false positives in the former API as surfaced in PR 280 the current supression rules don't handle newer versions of the scoped_threadpool crate trying to update the supression rules related to scoped_threadpool in PR #282 revealed that the supression rules are masking (hiding) real data races: #282 (comment) std::thread::scope requires less supression rules and does not mask real data races -- for instance, the data race in the linked issue comment is not masked when using std::thread::scope tradeoffs: - pro: one less dev dependency - pro: supressions file is simpler - cons: std::thread::scope is only available on recent nightlies
japaric
force-pushed
the
rm-scoped_threadpool
branch
from
a618e6a to
e809144
Compare
japaric
force-pushed
the
rm-scoped_threadpool
branch
from
e809144 to
57ac20e
Compare
Member
Author
|
r? @korken89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it's easier to deal with TSAN false positives in the former API
as it surfaced in PR #280 the current supression rules don't handle newer versions of the
scoped_threadpoolcratetrying to update the supression rules related to
scoped_threadpoolin PR #282 revealed that thesupression rules are masking (hiding) real data races:
#282 (comment)
std::thread::scoperequires less supression rules and does not mask real data races -- for instance,the data race in the linked issue comment is not masked when using
std::thread::scopetradeoffs:
std::thread::scopeis only available on recent nightlies but the API is only used in tests so it doesn't affect the MSRV