Refactor TargetInfo#397
Merged
Merged
Conversation
messense
force-pushed
the
more-targets
branch
from
January 26, 2026 13:40
1a0aaa7 to
7b333e6
Compare
messense
force-pushed
the
more-targets
branch
from
January 26, 2026 13:56
7b333e6 to
0e1dda0
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the TargetInfo struct to use lazy evaluation via methods instead of eager evaluation via precomputed boolean fields. The refactor improves code maintainability and adds several enhancements for platform and architecture detection.
Changes:
- Refactored
TargetInfofrom storing 11 boolean fields to computing target properties on-demand through methods - Added support for new architectures (aarch64, aarch64_be, riscv32) and Apple platforms (iOS, tvOS, watchOS, visionOS)
- Introduced
apple_cpu()method to return platform-appropriate Apple CPU types instead of hardcoded "apple_m1" - Wrapped
env::set_varcalls inunsafeblocks (required for Rust 1.80+)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.