bitcoin: update CompactSize Kani proofs#5955
Merged
apoelstra merged 1 commit intoApr 9, 2026
Merged
Conversation
tcharding
approved these changes
Apr 7, 2026
Member
|
Great! Thanks mate. |
Ari4ka
approved these changes
Apr 8, 2026
Contributor
Author
|
#5978 might help with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 existing Kani proofs, checking a CompactSize serialization/deserialization roundtrip for all
u32values andu64values greater than0xffffffff.These proofs no longer succeeded after #5697 implemented a range-check on CompactSize deserialization.
This PR updates the proofs such that a roundtrip is tested for all values in the enforced range, and values outside that range are rejected with
ParseError::OversizedCompactSize.Closes #5954