Revert "CI: Add formatting job"#5936
Merged
Merged
Conversation
Member
|
For more context: We added this job because of #5866, on the belief that it'd speed things up if everybody added format patches to their PRs, on pain of a red X in CI. Instead, rustfmt messed up the code almost immediately, meaning that every PR that actually tried to do this was NACKed while every other PR got a red X. We then got into a mode of always expecting CI to fail, which caused us not to notice the actual failure in #5899 (which was with the API files, something I don't test locally because of tooling difficulties). |
Member
|
CI should be fixed by #5914 (which of course means this needs a rebase..) |
Member
|
72c441b needs rebase |
This reverts commit cf39b40. As usual `rustfmt` is fucking us in the arse.
tcharding
force-pushed
the
push-olrvyvkyllvz
branch
from
72c441b to
1161549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cf39b40.
As usual
rustfmtis fucking us in the arse.Revert #5586 because of problems shown by the need for #5927