Skip to content

hashes: fmt skip a bunch of stuff#5927

Merged
apoelstra merged 2 commits into
rust-bitcoin:masterfrom
tcharding:push-mnmksklmouww
Mar 31, 2026
Merged

hashes: fmt skip a bunch of stuff#5927
apoelstra merged 2 commits into
rust-bitcoin:masterfrom
tcharding:push-mnmksklmouww

Conversation

@tcharding

Copy link
Copy Markdown
Member

Add attribute to a bunch of stuff recently introduced in #5888.

Add attribute to a bunch of stuff recently introduced in rust-bitcoin#5888.
@tcharding tcharding added the P-high High priority label Mar 31, 2026
@github-actions github-actions Bot added the C-hashes PRs modifying the hashes crate label Mar 31, 2026
@tcharding

Copy link
Copy Markdown
Member Author

Isn't needed if either #5612 or #5919 go in.

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ba4bbf; successfully ran local tests

@apoelstra apoelstra merged commit 7cb8aa6 into rust-bitcoin:master Mar 31, 2026
29 checks passed
@apoelstra

Copy link
Copy Markdown
Member

Merging this one since this has broken multiple PRs and I could get this one in quickly.

Honestly I am tempted to go back to the old rustfmt rules after this.

apoelstra added a commit that referenced this pull request Apr 2, 2026
1161549 Revert "CI: Add formatting job" (Tobin C. Harding)

Pull request description:

  This reverts commit cf39b40.
  
  As usual `rustfmt` is fucking us in the arse.
  
  Revert #5586 because of problems shown by the need for #5927


ACKs for top commit:
  apoelstra:
    ACK 1161549; successfully ran local tests


Tree-SHA512: 64d8d48c3ba8adbbe13ee295e8d794234b917668e2abce2c3d2d648fecd0c0b45dcbd7e27dafcd16d0c4d8eee568ded917b17515b88d21545a2e1b3c939c882e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-hashes PRs modifying the hashes crate P-high High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants