consensus_encoding: whitelist timeout mutants#5806
Merged
tcharding merged 1 commit intoMar 12, 2026
Conversation
tcharding
approved these changes
Mar 10, 2026
Member
|
Beg forgiveness don't ask permission: #5791 (comment) |
Member
|
👍 Yeah, my local CI system doesn't run the mutant-checker or validate these files in anyway. Go ahead and merge stuff like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly mutant job is failing with three timeout mutants in consensus_encoding.
It looks like the weekly job creates a github issue only for missed mutants, but not timeouts. Which is maybe by design? But then the diff check on PRs fails for timeouts so these are surfacing when the relevant code gets touched.
Following the existing pattern to whitelist these timeouts since they are pretty difficult to squash (every use in tests needs to be checked or the test hangs an poisons the whole
cargo testrun).