Skip to content

consensus_encoding: whitelist timeout mutants#5806

Merged
tcharding merged 1 commit into
rust-bitcoin:masterfrom
nyonson:whitelist-ce-timeout-mutants
Mar 12, 2026
Merged

consensus_encoding: whitelist timeout mutants#5806
tcharding merged 1 commit into
rust-bitcoin:masterfrom
nyonson:whitelist-ce-timeout-mutants

Conversation

@nyonson

@nyonson nyonson commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

The weekly mutant job is failing with three timeout mutants in consensus_encoding.

TIMEOUT  consensus_encoding/src/encode/mod.rs:183:12: delete ! in flush_to_vec in 0s build + 20s test
TIMEOUT  consensus_encoding/src/encode/mod.rs:227:12: delete ! in flush_to_writer in 0s build + 20s test
TIMEOUT  consensus_encoding/src/encode/encoders.rs:62:9: replace <impl Encoder for ArrayEncoder<N>>::advance -> bool with true in 0s build + 20s test

It looks like the weekly job creates a github issue only for missed mutants, but not timeouts. Which is maybe by design? But then the diff check on PRs fails for timeouts so these are surfacing when the relevant code gets touched.

Following the existing pattern to whitelist these timeouts since they are pretty difficult to squash (every use in tests needs to be checked or the test hangs an poisons the whole cargo test run).

@tcharding tcharding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ab8c46

@jamillambert jamillambert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ab8c46

@tcharding tcharding merged commit 2723c7b into rust-bitcoin:master Mar 12, 2026
28 checks passed
@tcharding

Copy link
Copy Markdown
Member

Beg forgiveness don't ask permission: #5791 (comment)

@apoelstra

Copy link
Copy Markdown
Member

👍 Yeah, my local CI system doesn't run the mutant-checker or validate these files in anyway. Go ahead and merge stuff like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants