Skip to content

primitives: Update API files#5764

Merged
tcharding merged 1 commit into
rust-bitcoin:masterfrom
mpbagot:feature/run-check-api
Mar 7, 2026
Merged

primitives: Update API files#5764
tcharding merged 1 commit into
rust-bitcoin:masterfrom
mpbagot:feature/run-check-api

Conversation

@mpbagot

@mpbagot mpbagot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

The API files for primitives are somehow behind on the tip of master, causing all CI to break for new PRs.

Update the api files using "just check-api"

Update the api files using "just check-api"
@mpbagot

mpbagot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Seems like this is my fault. Somehow the changes to the API files in #5480 missed the UnsafeUnpin trait.

@rustaceanrob

Copy link
Copy Markdown
Member

ACK 19b8dec

@nyonson

nyonson commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Seems like this is my fault. Somehow the changes to the API files in #5480 missed the UnsafeUnpin trait.

Possibly just a merge order issue with this one: #5723

@tcharding tcharding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 19b8dec

@tcharding

Copy link
Copy Markdown
Member

Can you push this up the queue please @apoelstra

@apoelstra

Copy link
Copy Markdown
Member

utACK 19b8dec

I will get to this as I grind through my notification queue, but go ahead and merge this without waiting @tcharding. I think this is blocking CI?

@tcharding tcharding merged commit 8c8a976 into rust-bitcoin:master Mar 7, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-high High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants