consensus_encoding: Remove prefix_read field#5079
Closed
tcharding wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
C-internals
tcharding
force-pushed
the
push-olloplxptwnk
branch
2 times, most recently
from
f1d61b7 to
7afe2ed
Compare
tcharding
changed the title
prefix_read field
We can just use the existence of the optional compact size decoder to abstract over whether the prefix has been read or not. We did this already for the `VecDecoder`. Internal change only, no logic change.
tcharding
force-pushed
the
push-olloplxptwnk
branch
from
7afe2ed to
305062d
Compare
github-actions
Bot
added
the
C-consensus_encoding
nyonson
approved these changes
Oct 8, 2025
apoelstra
added a commit
that referenced
this pull request
Oct 9, 2025
305062d consensus_encoding: Remove prefix_read field (Tobin C. Harding) Pull request description: We can just use the existence of the optional compact size decoder to abstract over whether the prefix has been read or not. We did this already in `VecDecoder`. Internal change only, no logic change. ACKs for top commit: nyonson: ACK 305062d apoelstra: ACK 305062d; successfully ran local tests Tree-SHA512: c78fbba2391519cac6d282d8bbd4c3448bd103e32d8c93fce17c7d1e7a76c39fc65a999e3c1c53c102fd5c7069eb38451a2f0da7f80bd446c8a16d78e5dc4da7
Member
|
This was merged, not closed, and by me, not @tcharding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can just use the existence of the optional compact size decoder to abstract over whether the prefix has been read or not.
We did this already in
VecDecoder.Internal change only, no logic change.