psbt: check that non-witness UTXOs' txids match the input txid#4637
Merged
Conversation
apoelstra
force-pushed
the
2025-06_fix-psbt
branch
from
a6dc02c to
28e6952
Compare
Pull Request Test Coverage Report for Build 15881559852Details
💛 - Coveralls |
tcharding
previously approved these changes
Jun 24, 2025
Member
Author
|
Gonna let this one sit for 48 hours since it's nontrivial (affects serde deserialization). Just in case Kix shows up and wants to comment. |
| NegativeFee, | ||
| /// Integer overflow in fee calculation | ||
| FeeOverflow, | ||
| /// Non-witness UTXO (which is a complete transaction) has txid that |
Contributor
There was a problem hiding this comment.
nit - txid is lower case here while the acronym is upper cased elsewhere.
Member
There was a problem hiding this comment.
Its like that all over the place, we could have an issue to fix it though.
gg txid | grep ///
Contributor
There was a problem hiding this comment.
I had meant in the context of this PR: /// The TXID of the non-witness UTXO.
Contributor
There was a problem hiding this comment.
Anyway, I think the best thing would be rustdoc links [`Txid`] when possible
Putting this in its own commit so that the fix and the test can live in separate commits which reviewers can swap.
This requires updating a couple serde test vectors -- we are tightening validation so that some existing serde-serialized PSBTs no longer deserialize. I believe this is the correct thing to do.
apoelstra
force-pushed
the
2025-06_fix-psbt
branch
from
28e6952 to
53b9332
Compare
tcharding
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4617