Remove schemars all together #3395
Conversation
|
I'm not sure it should be a separate issue -- if we drop this test crate then we won't know when |
tcharding
force-pushed
the
09-21-rm-schemars-test
branch
from
328cba7 to
d52c56c
Compare
tcharding
changed the title
We introduced schemars as a personal favor to a user, and it broke our CI repeatedly but eventually it seemed like it was stable (mainly, our MSRV caught up with its MSRV) so we just let it slide. In the end having schemars on hashes but nowhere else in the rust-bitcoin ecosystem did not prove that useful. Remove schemars all together. Fix: rust-bitcoin#3393
tcharding
force-pushed
the
09-21-rm-schemars-test
branch
from
d52c56c to
58704c2
Compare
|
I will let my ACK sit for 24 hours before merging to give Kix a chance to complain -- but because this is breaking CI I'll be more agressive about one-ack merging it than I normally would for a "rip out a feature" PR. |
|
FTR its an easy one to revert if needed. |
|
While reviewing #6163 this came up. Shall we backport this to 0.32 and 0.31 @apoelstra? I.e. remove schemars test crate all LTS branches. |
tcharding
added
port-0.32.x
No, that would be a breaking change. |
|
Woops, I did not realize there was code involved. I only hit the |
2 participants
We introduced schemars as a personal favor to a user, and it broke our CI repeatedly but eventually it seemed like it was stable (mainly, our MSRV caught up with its MSRV) so we just let it slide. In the end having schemars on hashes but nowhere else in the rust-bitcoin ecosystem did not prove that useful.
Remove schemars all together.
Fix: #3393