Skip to content

Replace some cfg(not by cfg_select#1850

Merged
gwenn merged 1 commit into
rusqlite:masterfrom
gwenn:cfg_select
May 24, 2026
Merged

Replace some cfg(not by cfg_select#1850
gwenn merged 1 commit into
rusqlite:masterfrom
gwenn:cfg_select

Conversation

@gwenn

@gwenn gwenn commented May 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented May 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.68%. Comparing base (73c360d) to head (38bef55).

Files with missing lines Patch % Lines
src/inner_connection.rs 77.27% 5 Missing ⚠️
src/raw_statement.rs 88.23% 2 Missing ⚠️
src/error.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1850      +/-   ##
==========================================
- Coverage   87.69%   87.68%   -0.02%     
==========================================
  Files          58       58              
  Lines       10937    10927      -10     
==========================================
- Hits         9591     9581      -10     
  Misses       1346     1346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwenn gwenn merged commit 863a5d2 into rusqlite:master May 24, 2026
18 checks passed
@gwenn gwenn deleted the cfg_select branch May 24, 2026 11:30
@djc

djc commented Jun 1, 2026

Copy link
Copy Markdown

This makes it impossible to use libsqlite3-sys on any version of Rust older than 1.95, which IMO is pretty hostile for what is a sort of low-level crate. Would you be open to a PR reverting this, committing to an explicitly maintained rust-version, and testing that that works in CI?

@gwenn

gwenn commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

This makes it impossible to use libsqlite3-sys on any version of Rust older than 1.95, which IMO is pretty hostile for what is a sort of low-level crate. Would you be open to a PR reverting this, committing to an explicitly maintained rust-version, and testing that that works in CI?

https://github.com/rusqlite/rusqlite#minimum-supported-rust-version-msrv

Latest stable Rust version at the time of release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants