Fix vtab::dequote#1835
Merged
Merged
Conversation
gwenn
force-pushed
the
dequote
branch
2 times, most recently
from
e00776b to
9bbd59a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the vtab argument parsing helpers to improve dequoting behavior (including support for additional quoting styles) and propagates the new Cow<str>-based return type through virtual table modules.
Changes:
- Reworked
vtab::dequoteto returnCow<str>and attempt to handle inner escaped quotes. - Updated
vtab::parameterto return aCow<str>value and adjusted vtab modules to consume it. - Expanded unit tests for
dequoteand updated parameter parsing tests for the new return type.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/vtab/mod.rs |
Refactors dequote/parameter to use Cow<str> and extends dequoting logic + tests. |
src/vtab/vtablog.rs |
Adapts vtablog argument parsing to the new parameter() return type. |
src/vtab/csvtab.rs |
Adapts csvtab argument parsing to the new parameter() return type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1835 +/- ##
==========================================
+ Coverage 87.54% 87.57% +0.02%
==========================================
Files 58 58
Lines 10794 10825 +31
==========================================
+ Hits 9450 9480 +30
- Misses 1344 1345 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.