Allow opting out of using sqlite-wasm-rs on wasm32-unknown-unknown#1829
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 58 58
Lines 10824 10824
=======================================
Hits 9476 9476
Misses 1348 1348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #1828 by leaning into cargo feature flags and target dependencies.
Note: this will technically be a breaking change for anyone building for
wasm32-unknown-unknownwithrusqlite = { default-features = false }as they will now need to opt intorusqlite/ffi-sqlite-wasm-rs. Though this seemed like a better tradeoff than makingffi-sqlite-wasm-rsa non-default feature and requiring everyone who currently builds forwasm32-unknown-unknownto then have to enablerusqlite/ffi-sqlite-wasm-rs.Please let me know if you'd prefer I take a different direction!