Use TryFrom<ValueRef> for Value#1819
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
==========================================
- Coverage 87.96% 87.88% -0.08%
==========================================
Files 58 58
Lines 10648 10657 +9
==========================================
Hits 9366 9366
- Misses 1282 1291 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Awesome, thanks for addressing this so quickly. Any rough ETA on next release? It's not urgent by any means but it's making me use different code paths temporarily and I don't want them to ossify and never be revised, which sadly tends to happen with time. |
dimitarvp
reviewed
Mar 14, 2026
Comment on lines
+153
to
155
|
|
||
| #[inline] | ||
| #[track_caller] |
There was a problem hiding this comment.
btw #[track_caller] is not useful on a function that never panics. Harmless but, FYI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1817