Add support for transaction to the vtab module#1696
Closed
jwhear wants to merge 1 commit into
Closed
Conversation
The virtual table interface allows xBegin, xSync, xCommit, and xRollback to be defined. This commit provides a trait, `TransactionVTab` and rustified versions of those methods. Note that the `module` macro is getting a bit cumbersome and should possibly be redesigned.
Collaborator
Collaborator
Just for reference: |
Collaborator
|
Sorry for the delay, PR fixed (minor) and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtual table interface allows xBegin, xSync, xCommit, and xRollback to be defined. This commit provides a trait,
TransactionVTaband rustified versions of those methods.Note that the
modulemacro is getting a bit cumbersome and should possibly be redesigned. Additionally thereadonly_module,update_module, andupdate_module_with_txmethods simply aren't going to scale if other orthogonal virtual table features are added. It's not obvious to me what a better design would be but I'm happy to take suggestions.