Skip to content

Feature loadable_extension is incompatible with some other features#1686

Merged
gwenn merged 2 commits into
rusqlite:masterfrom
gwenn:all_features
Apr 24, 2025
Merged

Feature loadable_extension is incompatible with some other features#1686
gwenn merged 2 commits into
rusqlite:masterfrom
gwenn:all_features

Conversation

@gwenn

@gwenn gwenn commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

At least preupdate_hook and session.

@codecov

codecov Bot commented Apr 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (fa1be08) to head (ca3958d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          58       58           
  Lines       11110    11110           
=======================================
  Hits         9661     9661           
  Misses       1449     1449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwenn

gwenn commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator Author

Ignore unrelated sqlcipher error

@gwenn gwenn merged commit ca23ad9 into rusqlite:master Apr 24, 2025
@gwenn gwenn deleted the all_features branch April 24, 2025 06:15
@SabrinaJewson

Copy link
Copy Markdown

This makes it worse, doesn’t it? Now buildling with --all-features doesn’t work at all, which I think would very be annoying for new contributors.

@gwenn

gwenn commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator Author

This makes it worse, doesn’t it? Now buildling with --all-features doesn’t work at all, which I think would very be annoying for new contributors.

https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features

There are rare cases where features may be mutually incompatible with one another. This should be avoided if at all possible, because it requires coordinating all uses of the package in the dependency graph to cooperate to avoid enabling them together. If it is not possible, consider adding a compile error to detect this scenario.

But:

When there is a conflict, choose one feature over another.

which may be feasible...
(before this PR, -all-features was not working as expected so at least, for now, there is no surprise. And for me, the worst is trying to make -all-features work with loadable_extension not ignored)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants