Use C string literal for database name#1596
Merged
Merged
Conversation
No alloc for "main" and "temp". No alloc possible when the attached database name is known at compile time / a C string literal can be usd. No alloc when the database name is given by SQLite (`sqlite3_wal_hook`).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.03%
==========================================
Files 58 58
Lines 10814 10816 +2
==========================================
- Hits 9291 9290 -1
- Misses 1523 1526 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No alloc for "main" and "temp".
No alloc possible when the attached database name is known at compile time / a C string literal can be usd.
No alloc when the database name is given by SQLite (
sqlite3_wal_hook).