Skip to content

Add safe binding to sqlite3_wal_hook#1594

Merged
gwenn merged 2 commits into
rusqlite:masterfrom
gwenn:wal_hook
Nov 10, 2024
Merged

Add safe binding to sqlite3_wal_hook#1594
gwenn merged 2 commits into
rusqlite:masterfrom
gwenn:wal_hook

Conversation

@gwenn

@gwenn gwenn commented Nov 10, 2024

Copy link
Copy Markdown
Collaborator

Fix #1187 and #1570

@codecov

codecov Bot commented Nov 10, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (e8749fc) to head (6db7d47).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/lib.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
+ Coverage   85.87%   85.91%   +0.04%     
==========================================
  Files          58       58              
  Lines       10765    10814      +49     
==========================================
+ Hits         9244     9291      +47     
- Misses       1521     1523       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gwenn gwenn merged commit 0af8bfc into rusqlite:master Nov 10, 2024
@gwenn gwenn deleted the wal_hook branch November 10, 2024 11:28
@gwenn

gwenn commented Nov 10, 2024

Copy link
Copy Markdown
Collaborator Author

TODO: give access to the sqlite3 handle / &Connection.
But creating a Connection / StatementCache might be overkill for just calling sqlite3_wal_checkpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support WAL hook

1 participant