Skip to content

OwningRows / OwningStatement examples#1462

Merged
gwenn merged 8 commits into
rusqlite:masterfrom
gwenn:owning
Dec 6, 2024
Merged

OwningRows / OwningStatement examples#1462
gwenn merged 8 commits into
rusqlite:masterfrom
gwenn:owning

Conversation

@gwenn

@gwenn gwenn commented Mar 3, 2024

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Mar 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (19a4c55) to head (447e9da).
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
+ Coverage   85.81%   86.34%   +0.53%     
==========================================
  Files          57       56       -1     
  Lines       10664    10907     +243     
==========================================
+ Hits         9151     9418     +267     
+ Misses       1513     1489      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gwenn

gwenn commented Mar 28, 2024

Copy link
Copy Markdown
Collaborator Author

Maybe for Statement we can let user have their own implementation of the cache.
(with a nice side effect: hashlink dependency becomes optional)
And if we let user retrieve the cache key (possibly a simple index), a cached statement can be retrieved with O(1) versus the current O(nlog(n)).

Comment thread Cargo.toml Outdated
@gwenn gwenn marked this pull request as draft October 7, 2024 10:00
@gwenn gwenn marked this pull request as ready for review December 6, 2024 17:32
@gwenn gwenn merged commit d3f04ae into rusqlite:master Dec 6, 2024
@gwenn gwenn deleted the owning branch December 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant