Skip to content

Conversation

@monstruosoft
Copy link
Contributor

In this PR I added the Upscaler tab to the Qt GUI. Please note that I currently don't have the AURA-SR model installed, nor enough HDD space to download it so I can't test it and as such it's currently disabled. It should work but I have no way to try it.
Also in this PR, I finally removed the duplicated code in app_window.py for the txt2img workflow and replaced it with the corresponding code provided by an instance of the widget class defined in base_widget.py. Hopefully nothing broke with these changes.

Will try to continue working on adding to the Qt version the remaining options supported by the CLI and WebUI versions.

Remove duplicated code for txt2img mode in app_window.py by
replacing the code for the txt2img GUI with an instance of the
BaseWidget class.
Add a signal to restore the original behavior and enable/disable
negative prompt editing depending on its support in the current
image generation mode
Add Upscaler tab to the Qt GUI
@rupeshs
Copy link
Owner

rupeshs commented Feb 8, 2025

image
@monstruosoft

  1. We need to support all upscale modes, enable AURA upscale please use this backend function upscale_image ( All UI modes should depend on the backend)
    def upscale_image(
  2. Instead of "Generate" button text it would be nice to use "Upscale" as button text.
  3. Also please ensure that this UI update does not break any existing functionality (Fastsdcpu is following loosely coupled architecture)

Enable AURA-SR upscale in the Qt GUI
@monstruosoft
Copy link
Contributor Author

Done. Hopefully it works fine.

I try my best not to break any existing functionality. Besides, I haven't made any changes outside of the Qt GUI frontend folder.

@rupeshs
Copy link
Owner

rupeshs commented Feb 10, 2025

Done. Hopefully it works fine.

I try my best not to break any existing functionality. Besides, I haven't made any changes outside of the Qt GUI frontend folder.

@monstruosoft
Thanks, since this is an upscaler we don't need to give denoising strength(remove the slider from GUI), we can make GUI similar to webui

image

@monstruosoft
Copy link
Contributor Author

I left the denoising strength slider on for the SD upscale. I think SD upscale can give some good upscale results with lower denoising strength values between 0.1 and up to 0.3 or even 0.4, depending on the image. Maybe I can set the label to "Denoising strength for SD upscale"? Or should I remove the slider completely?.

@rupeshs
Copy link
Owner

rupeshs commented Feb 10, 2025

I left the denoising strength slider on for the SD upscale. I think SD upscale can give some good upscale results with lower denoising strength values between 0.1 and up to 0.3 or even 0.4, depending on the image. Maybe I can set the label to "Denoising strength for SD upscale"? Or should I remove the slider completely?.

We can remove it as of now.

Remove denoising strength upscale slider in Qt GUI
@monstruosoft
Copy link
Contributor Author

OK, I removed it.

@rupeshs rupeshs merged commit b0e1449 into rupeshs:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants