-
Notifications
You must be signed in to change notification settings - Fork 172
Added Upscaler tab to the Qt GUI #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove duplicated code for txt2img mode in app_window.py by replacing the code for the txt2img GUI with an instance of the BaseWidget class.
Add a signal to restore the original behavior and enable/disable negative prompt editing depending on its support in the current image generation mode
Add Upscaler tab to the Qt GUI
|
Enable AURA-SR upscale in the Qt GUI
|
Done. Hopefully it works fine. I try my best not to break any existing functionality. Besides, I haven't made any changes outside of the Qt GUI frontend folder. |
@monstruosoft |
|
I left the denoising strength slider on for the SD upscale. I think SD upscale can give some good upscale results with lower denoising strength values between 0.1 and up to 0.3 or even 0.4, depending on the image. Maybe I can set the label to "Denoising strength for SD upscale"? Or should I remove the slider completely?. |
We can remove it as of now. |
Remove denoising strength upscale slider in Qt GUI
|
OK, I removed it. |


In this PR I added the Upscaler tab to the Qt GUI. Please note that I currently don't have the AURA-SR model installed, nor enough HDD space to download it so I can't test it and as such it's currently disabled. It should work but I have no way to try it.
Also in this PR, I finally removed the duplicated code in app_window.py for the txt2img workflow and replaced it with the corresponding code provided by an instance of the widget class defined in base_widget.py. Hopefully nothing broke with these changes.
Will try to continue working on adding to the Qt version the remaining options supported by the CLI and WebUI versions.