Fix ability to specify flank version.#97
Merged
Merged
Conversation
runningcode
commented
Apr 24, 2020
| ``` groovy | ||
| fladle { | ||
| serviceAccountCredentials("${project.file("flank-gradle-service-account.json")}") | ||
| serviceAccountCredentials = project.layout.projectDirectory.file("flank-gradle-service-account.json") |
runningcode
commented
Apr 24, 2020
|
|
||
| ### flankVersion | ||
| `flankVersion("flank_snapshot")` to specify a Flank snapshot. | ||
| `flankVersion = "flank_snapshot"` to specify a Flank snapshot. |
runningcode
force-pushed
the
no/property
branch
from
April 24, 2020 22:43
20add12 to
3d649ee
Compare
We need to specify the version inside the `afterEvaluate` block otherwise the extension isn't set yet. This also uses the new property api. This avoids touching the filesystem during the configuration phase of Gradle. More information on working with files can be found here: https://docs.gradle.org/current/userguide/working_with_files.html
runningcode
force-pushed
the
no/property
branch
from
April 24, 2020 22:45
3d649ee to
a47375c
Compare
bootstraponline
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to specify the version inside the
afterEvaluateblockotherwise the extension isn't set yet.
This also uses the new property api.
This avoids touching the filesystem during the configuration phase of
Gradle.
More information on working with files can be found here:
https://docs.gradle.org/current/userguide/working_with_files.html