Add support additional-app-test-apks#83
Conversation
|
Hey, thanks for the contribution! I'd like to not use a custom class here. I like where this is going though. Perhaps if this were a Map<String, String> I think it would work. |
|
Hey thanks for the update, what do you think of using |
|
Sounds good! |
|
Updated |
|
Hey, sorry, I must have missed this in the first review. I was looking at this from mobile. I would like to be able to keep the current api with |
|
I've updated again with restored debugApk and instrumentationApk fields |
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
Looks great! I just need to think over if I like the explicit way you specified the debug apks for each instrumentation apk. I think it can make it easier to debug the flank configs. Thoughts?
| appendln(" - $file") | ||
| } | ||
| } | ||
| val testApks = config.additionalTestApks.flatMap { (debugApk, instrumentationApks) -> |
There was a problem hiding this comment.
This code can be somewhat simplified a bit since the instrumentation apk will take whatever value is above is as the debug apk. See the readme. https://github.com/TestArmada/flank/blob/master/README.md
if (config.additionalTestApks.isNotEmpty()) {
appendln(" additional-app-test-apks:")
config.additionalTestApks.entries.forEach { debugApk, instrumentationApks ->
appendln(" - app: ${debugApk}")
instrumentationApks.forEach {
appendln(" test: ${it}")
}
}
On the other hand, I do like the more explicit output format that you created here. Let me think this one over overnight. :)
There was a problem hiding this comment.
Should I change this?
| } | ||
| checkNotNull(base.debugApk!!) { "debugApk file cannot be null ${base.debugApk}" } | ||
| checkNotNull(base.instrumentationApk!!) { "instrumentationApk file cannot be null ${base.instrumentationApk}" } | ||
| base.additionalTestApks.forEach { |
| ### instrumentationApk | ||
| This is the path to the app's instrumentation apk. | ||
|
|
||
| ### additionalTestApks |
There was a problem hiding this comment.
can you add a short sample? and that it is a map of debug apks to a list of instrumentation apks? thanks :)
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
Let's do this! Sorry for not responding earlier.
2 participants
Let me know if this dsl is acceptable if not, let me know how to adjust it.