Skip to content

Support flank version 8.1.0#77

Merged
runningcode merged 3 commits into
runningcode:masterfrom
tahirhajizada:support-flank-8.1.0
Nov 7, 2019
Merged

Support flank version 8.1.0#77
runningcode merged 3 commits into
runningcode:masterfrom
tahirhajizada:support-flank-8.1.0

Conversation

@tahirhajizada

@tahirhajizada tahirhajizada commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Add new feature from flank version 8.1.0.
keep-file-path
Keeps the full path of downloaded files from a Google Cloud Storage bucket. Required when file names are not unique. Disabled by default.

@runningcode

Copy link
Copy Markdown
Owner

Hey, thanks for the contribution. Can we add some documentation to the readme around this flag and what it does?

@tahirhajizada

Copy link
Copy Markdown
Contributor Author

@runningcode Yes sure. I was going to add it.

@tahirhajizada

Copy link
Copy Markdown
Contributor Author

@runningcode I see there is already one open PR with version 0.7.2-SNAPSHOT, in this case which version should I put?

@tahirhajizada
tahirhajizada marked this pull request as ready for review November 4, 2019 11:00
Comment thread README.md
The name of a Google Cloud Storage bucket where raw test results will be stored.

### keepFilePath
Keeps the full path of downloaded files from a Google Cloud Storage bucket. Required when file names are not unique. Disabled by default.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what file names would not be unique? how does one know that one should enable this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example. When the toggle is disabled downloaded files are stored at the root of device.
results/2019-09-20-13-57-45.1454_nGys/shard_0/NexusLowRes-28-en-portrait/file.png

But when it is enabled, then the full path of the file kept.
results/2019-09-20-13-57-45.1454_nGys/shard_0/NexusLowRes-28-en-portrait/{package name}/file.png

@runningcode runningcode left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@runningcode
runningcode merged commit fadcea7 into runningcode:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants