Support Flank 8.x.x#75
Merged
runningcode merged 4 commits intoOct 18, 2019
Merged
Conversation
runningcode
reviewed
Oct 18, 2019
runningcode
left a comment
runningcode
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution. It looks great. I just have one preference in this repository. Using VersionNumber instead of a regex.
| } | ||
|
|
||
| private fun isFlankVersionAtLeast(flankVersion: String, major: Int): Boolean { | ||
| val matchResult = FLANK_VERSION_REGEX.matchEntire(flankVersion) |
Owner
There was a problem hiding this comment.
This solution works, but I would prefer if we tried to use the more idiomatic VersionNumber api in gradle. Can you try to see if this same thing can be achieved with VersionNumber.parse(flankVersion).getMajor() > major?
runningcode
approved these changes
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flank 8.0.0 added two breaking changes.
flaky-test-attemptshas been renamed tonum-flaky-test-attemptsrepeat-testshas been renamed tonum-test-runsThis PR adds support for Flank 8 maintaining support for older Flank's versions at the same time.