Add support for all currently available configuration options#26
Merged
runningcode merged 1 commit intoFeb 21, 2019
Merged
Conversation
Added support for a map of environment-variables Removed clearPackageData in favor of that Added support for directories-to-pull and files-to-download Added support for timeout in minutes Added support for record-video Added support for performance-metrics
Contributor
Author
|
@runningcode ended up unfortunately to be a bit more changes than expected but I didn't want to have a separate PR for each option - hope that's fine to you :) |
runningcode
approved these changes
Feb 21, 2019
runningcode
left a comment
runningcode
left a comment
Owner
There was a problem hiding this comment.
Looks great! Thanks for doing this.
| val configs: NamedDomainObjectContainer<FladleConfigImpl> = project.container(FladleConfigImpl::class.java) { | ||
| FladleConfigImpl(it, flankVersion, projectId, serviceAccountCredentials, useOrchestrator, autoGoogleLogin, clearPackageData, devices, testTargets, testShards, repeatTests, smartFlankGcsPath, resultsHistoryName, flakyTestAttempts) | ||
| FladleConfigImpl( | ||
| name = it, |
Owner
There was a problem hiding this comment.
ah, thanks for breaking this up!
| val testTargets = extension.testTargets | ||
| extension.resultsHistoryName?.let { | ||
| builder.appendln(" results-history-name: $it") | ||
| internal fun writeAdditionalProperties(config: FladleConfig): String = buildString { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for a map of environment-variables
Removed clearPackageData in favor of that
Added support for directories-to-pull and files-to-download
Added support for timeout in minutes
Added support for record-video
Added support for performance-metrics