Added more fields to fulladleModuleConfig#257
Merged
runningcode merged 13 commits intoJun 2, 2021
Conversation
Modules can now be omitted with
```
fulladleModuleConfig {
enabled = false
}
```
fixes runningcode#202
runningcode
reviewed
May 21, 2021
runningcode
left a comment
runningcode
left a comment
Owner
There was a problem hiding this comment.
looks very good. just some nits
| val environmentVariables: MapProperty<String, String> = objects.mapProperty() | ||
|
|
||
| /** | ||
| * the app under test |
Owner
There was a problem hiding this comment.
is this a fully qualified path to the apk under test?
Contributor
Author
There was a problem hiding this comment.
what do you mean by fully qualified path? the absolute path?
…duleExtension.kt Co-authored-by: Nelson Osacky <[email protected]>
…duleExtension.kt Co-authored-by: Nelson Osacky <[email protected]>
…an/fladle into asalman/override-module-config2
Owner
|
Could you run |
added 2 commits
May 23, 2021 23:37
|
Buildscan url for run 900828157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to override certain fields for modules when using Fulladle.
You can override the following properties for any module: