Support new Flank options without updating Fladle#214
Merged
runningcode merged 9 commits intoFeb 1, 2021
Merged
Conversation
runningcode
requested changes
Jan 23, 2021
runningcode
left a comment
runningcode
left a comment
Owner
There was a problem hiding this comment.
This looks great. A lot of people were asking for this. Thanks for adding this support. Just some nitpicks here and there.
Co-authored-by: Nelson Osacky <[email protected]>
runningcode
reviewed
Jan 25, 2021
runningcode
left a comment
runningcode
left a comment
Owner
There was a problem hiding this comment.
Very close, just some nits on the docs. You can also add this to the docs/changelog if you like!
Co-authored-by: Nelson Osacky <[email protected]>
Co-authored-by: Nelson Osacky <[email protected]>
Co-authored-by: Nelson Osacky <[email protected]>
Contributor
Author
Thanks for the review and fixes, I have updated changelog |
Contributor
Author
|
@runningcode could you re-check? |
runningcode
approved these changes
Feb 1, 2021
runningcode
left a comment
runningcode
left a comment
Owner
There was a problem hiding this comment.
This looks great. This has been asked for a lot!
|
Buildscan url for run 528445073 |
piotradamczyk5
deleted the
#146-support_new_flank_options_without_updating_fladle
branch
February 2, 2021 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146
Added 2 new options (
additionalFlankConfigandadditionalGcloudConfig) for support appending not supported option by Fladle to yaml file