Write Yaml file to task specific output directory#161
Merged
runningcode merged 2 commits intoAug 27, 2020
Conversation
runningcode
reviewed
Aug 14, 2020
CristianGM
force-pushed
the
write-yaml-to-specific-directory
branch
2 times, most recently
from
August 18, 2020 13:32
a833992 to
c2ba0ff
Compare
CristianGM
force-pushed
the
write-yaml-to-specific-directory
branch
from
August 24, 2020 13:26
c2ba0ff to
7a41959
Compare
runningcode
approved these changes
Aug 27, 2020
Owner
|
Thanks so much for this contribution! |
runningcode
reviewed
Aug 27, 2020
| } | ||
|
|
||
| private fun TaskContainer.createTasksForConfig(base: FlankGradleExtension, config: FladleConfig, project: Project, name: String) { | ||
| val writeConfigProps = register("writeConfigProps$name", YamlConfigWriterTask::class.java, base) |
Owner
There was a problem hiding this comment.
@CristianGM curious, why did you remove passing the config in the constructor here and instead set it during the configuration?
Contributor
Author
There was a problem hiding this comment.
can I declare a Task input as a constructor parameter?
Contributor
Author
There was a problem hiding this comment.
I guess I could just add a getter to declare the input.
But actually is that I never used constructor parameters for a task (unless for injected services) and the documentation doesn't mention them a lot.
Owner
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147
I know there are some duplicates, but even worst I'm doing a lot in configuration phase, with the change to Gradle 6.0 and using ExecOperations I had that done in a better way, only reading values at execution phase.