Fix incomplete PWM initialization for 8th slice.#1
Merged
runger1101001 merged 1 commit intorunger1101001:devfrom Sep 16, 2022
Merged
Fix incomplete PWM initialization for 8th slice.#1runger1101001 merged 1 commit intorunger1101001:devfrom
runger1101001 merged 1 commit intorunger1101001:devfrom
Conversation
runger1101001
approved these changes
Sep 16, 2022
Owner
|
Excellent find. Will merge and the fix will make its way into the next release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes our second channel. I found with an oscilloscope that pins 14 and 15 never had any PWM output, and found with a debugger that the associated PWM channel was never enabled. I found this line which intends to enable all channels at once, but uses a mask that misses that last channel. I confirmed the motor now calibrates and works with this fix.