Merged
Conversation
rictic
approved these changes
Apr 5, 2023
…duced in `4.0.2`). (cherry-pick c69e804)
Somewhere between 3.8 and 5.0, indentation for JSDoc description lines starting with whitespace was fixed to not include the additional space immediately after the line's leading `*`. The indentiation in this test causes it to fail in at least TS 5.0, so I'm removing it rather than trying to track down exactly when this change was made and then propagating the version number to the test.
bicknellr
force-pushed
the
typescript-compat
branch
from
e14219b to
e85927f
Compare
…6 instead of v9.
rictic
approved these changes
Apr 6, 2023
Contributor
Author
|
For reference, this is the same error I was seeing before I downgraded |
Contributor
Author
|
That issue might be for lit-analyzer actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typescript@~5.0to the list of TS versions that this package is tested on.[email protected].isTypeAssertion(compiler API) andDocumentAndElementEventListeners(TS's DOM types).