Make sure the mount is readonly when searching for a user/group #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
Sep 15, 2022
ndeloof
approved these changes
Sep 15, 2022
Mounting the same directory twice with overlayfs will put the mounts in an undefined behavior. We need to make sure that the mounts we do are read-only. Signed-off-by: Djordje Lukic <[email protected]>
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mounting the same directory twice with overlayfs will put the mounts in an undefined behavior. We need to make sure that the mounts we do are read-only.
- What I did
Took the code from containerd and added the
ReadonlyMountsmethod to make sure that we are mounting in read-only mode.- How I did it
- How to verify it
Run
docker run -it --user 1000 docker/dev-environments-go:stable-1and then, in a different terminal, exec into that container, try to create a file, it should work and not fail withNo such file or directory.- A picture of a cute animal (not mandatory but encouraged)
