Containerd diff #91
Merged
Containerd diff #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
rumpl
reviewed
Sep 15, 2022
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
containerd_diff
branch
from
a707324 to
1e04143
Compare
rumpl
approved these changes
Sep 15, 2022
|
This doesn't seem cherrypicked in the |
Owner
|
@AkihiroSuda no blocker really, upstreaming just takes time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Implement
docker difffor containerd snapshotterthis mounts parent image and compare content with container's root filesystem.
due to containerd design, we don't have access to container's rootfs so need to create a dedicated temporary (readonly) mount
- A picture of a cute animal (not mandatory but encouraged)
