Set the user on exec #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
force-pushed
the
exec-user
branch
6 times, most recently
from
d459f61 to
62a2e2d
Compare
ndeloof
reviewed
Sep 12, 2022
| return err | ||
| } | ||
| opts := []oci.SpecOpts{ | ||
| coci.WithUser(ec.User), |
Collaborator
There was a problem hiding this comment.
I wonder this should be guarded by ec.User != nil. Otherwise, if no explicit user is set, this will reset additionalGIDs without any replacement
Owner
Author
There was a problem hiding this comment.
It's guarded by if len(ec.User) > 0
ndeloof
approved these changes
Sep 12, 2022
Collaborator
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
LGTM, with an open question on nil ec.User
ndeloof
approved these changes
Sep 12, 2022
| return err | ||
| } | ||
| opts := []oci.SpecOpts{ | ||
| coci.WithUser(ec.User), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed exec when specifiying a user:
- How I did it
By getting the container from containerd and asking it to populate the spec with the right user.